Dataford
Interview QuestionsInterview GuidesExperiencesCoaching
New
Pricing
Get started
Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
Experiences
Practice
Mock InterviewsTimed interview simulations with feedbackCoaching1:1 coaching with people at your target companiesSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Build my plan

Review Java Code and Find Errors

MediumCoding00:00
Practice interviewer
In session
5 left
00:00

Your question is Review Java Code and Find Errors. Take a moment with it on the right.

Talk me through your thinking if you like. When you're confident, submit your answer and I'll grade it like a real screen (7/10 or better passes).

You need to log in / sign up to chat or submit.

Problem

This dispatcher queues outgoing commands to a field device and is meant to retry anything that fails to send, tracking the failure rate for an operator dashboard.

import java.util.ArrayList;
import java.util.List;

public class TelemetryDispatcher {

    private List<String> pendingCommands = new ArrayList<>();
    private int retryCount = 0;

    public void enqueue(String command) {
        pendingCommands.add(command);
    }

    public void dispatchAll() {
        for (String command : pendingCommands) {
            boolean sent = sendToDevice(command);
            if (!sent) {
                retryCount++;
                pendingCommands.remove(command);
            }
        }
    }

    public boolean sendToDevice(String command) {
        if (command.length() > 256) {
            return false;
        }
        System.out.println("Sending: " + command);
        return true;
    }

    public double getFailureRate() {
        return retryCount / pendingCommands.size();
    }
}

Review this Java code and find every error in it, including anything that would crash at runtime and anything that silently produces a wrong number. Explain each one and how you would fix it.