Dataford
Interview QuestionsInterview GuidesExperiencesMock InterviewsPricing
Get started

Review and Improve Code

HardBehavioral & Leadership00:00
Practice interviewer
In session
5 left
00:00

Your question is Review and Improve Code. Take a moment with it on the right.

Talk me through your thinking if you like. When you're confident, submit your answer and I'll grade it like a real screen (7/10 or better passes).

You need to log in / sign up to chat or submit.

Problem

MongoDB's docs team publishes runnable code samples alongside each API reference page. A drafted Node.js snippet for the "paginate a collection" tutorial is below, meant to fetch orders for a storefront database. Before it goes live, interpret what the code actually does, point out every coding error you can find, and suggest how you would improve it.

const { MongoClient } = require("mongodb");

const client = new MongoClient("mongodb://docsUser:Sup3rSecret!@cluster0.mongodb.net/atlas");

async function getOrdersPage(page, pageSize) {
  client.connect();

  const db = client.db("storefront");
  const orders = db.collection("orders");

  const results = await orders
    .find({ Status: "active" })
    .limit(pageSize * page)
    .toArray()
    .catch(err => console.log(err));

  console.log(`Found ${results.length} orders`);
  return results;
}

getOrdersPage(2, 10);

Walk through the snippet line by line and explain each error you find and why it matters to a developer who copies this into production.