Dataford
Interview QuestionsInterview GuidesExperiencesMock InterviewsPricing
Get started
Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
Experiences
Practice
Mock InterviewsTimed interview simulations with feedbackSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Build my plan

Refactor Provided Code

MediumCoding00:00
Practice interviewer
In session
5 left
00:00

Your question is Refactor Provided Code. Take a moment with it on the right.

Talk me through your thinking if you like. When you're confident, submit your answer and I'll grade it like a real screen (7/10 or better passes).

You need to log in / sign up to chat or submit.

Problem

Xero's invoicing service has a method that finalizes an invoice: it converts the subtotal to NZD, applies GST, writes the total back to the database, and alerts finance if the invoice is unusually large. Nobody has ever written a unit test against it, and a new hire has been asked to refactor it and say exactly where test coverage should go.

public class InvoiceService
{
    public decimal FinalizeInvoice(int invoiceId, decimal subtotal, string currencyCode)
    {
        var connection = new SqlConnection("Server=prod-sql;Database=Xero;Trusted_Connection=True;");
        connection.Open();

        decimal converted = CurrencyConverter.ConvertToNZD(subtotal, currencyCode);

        decimal gst = converted * 0.15m;
        decimal total = converted + gst;

        var query = "UPDATE Invoices SET Total = " + total + " WHERE Id = " + invoiceId;
        var cmd = new SqlCommand(query, connection);
        cmd.ExecuteNonQuery();

        if (total > 10000)
        {
            EmailNotifier.SendHighValueAlert(invoiceId, total);
        }

        Console.WriteLine($"Invoice {invoiceId} finalized at {DateTime.Now}");

        return total;
    }
}

Refactor this method and explain, point by point, everything that currently makes it impossible to unit test, where you would add coverage once it's testable, and any other issue you notice along the way.