Dataford
Interview QuestionsInterview GuidesExperiencesCoaching
New
Pricing
Get started
Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
ExperiencesCoaching
New
Practice
Mock InterviewsTimed interview simulations with feedbackSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Get started
Refactor for Maintainability
00:00
5 left

Refactor for Maintainability

HardPython

Problem

Docker's registry service validates and resolves image tags before fetching their manifests. A Backend Engineer candidate is shown this Go function and told a single bad request from a client recently took down the whole registry process.

func ProcessImageTag(registry string, image string, tag string) *Manifest {
    if registry != "" {
        if image != "" {
            if tag != "" {
                if len(tag) < 128 {
                    if tag != "latest" {
                        fullRef := registry + "/" + image + ":" + tag
                        manifest, _ := fetchManifest(fullRef)
                        log.Printf("fetched manifest for %s", fullRef)
                        return manifest
                    } else {
                        fullRef := registry + "/" + image + ":latest"
                        manifest, _ := fetchManifest(fullRef)
                        log.Printf("fetched manifest for %s", fullRef)
                        return manifest
                    }
                } else {
                    panic("tag too long")
                }
            } else {
                panic("tag required")
            }
        } else {
            panic("image required")
        }
    } else {
        panic("registry required")
    }
    return nil
}

Refactor this to improve its readability and maintainability. Explain what's wrong with the current version, including whatever caused the outage, and what you'd change.

Implement the validation portion as process_image_reference(registry, image, tag). Return a dictionary containing either reference or error; fetching the manifest is outside this function.

Constraints

  • Each input is a string.
  • registry, image, and tag may be empty.
  • A tag is valid only when its length is less than 128.
  • The function must not fetch a manifest or terminate the process.

Function Signature

def process_image_reference(registry, image, tag):
Interviewer

Your question is Refactor for Maintainability. Start with the requirements in the Question tab.

Run and submit as often as you like. When you're ready, talk me through your approach or go straight to the code.

You need to log in / sign up to run or submit.
Code
Sign up free to run your codeLog inLn 2
Run your code to see test output here.