Dataford
Interview QuestionsInterview GuidesExperiencesCoaching
New
Pricing
Get started
Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
Experiences
Practice
Mock InterviewsTimed interview simulations with feedbackCoaching1:1 coaching with people at your target companiesSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Build my plan

Improve Provided Code

MediumCoding00:00
Practice interviewer
In session
5 left
00:00

Your question is Improve Provided Code. Take a moment with it on the right.

Talk me through your thinking if you like. When you're confident, submit your answer and I'll grade it like a real screen (7/10 or better passes).

You need to log in / sign up to chat or submit.

Problem

Simplisafe's alarm service evaluates a batch of sensor events (door/window sensors, motion sensors) to decide whether to trigger an alert, then formats a message naming which sensors fired. A teammate wrote the two functions below and asked for a second pair of eyes before it goes into the alarm pipeline.

def evaluate_alarm(events, triggered_sensors=[]):
    for event in events:
        try:
            sensor_id = event["sensor_id"]
            status = event["status"]
            if status == "open" or status == "motion":
                triggered_sensors.append(sensor_id)
            if len(triggered_sensors) > 3:
                return True
        except:
            print("bad event")
    if len(triggered_sensors) >= 3:
        return True
    return False


def format_alert(sensor_ids):
    msg = "Alert triggered by sensors: "
    for i in range(len(sensor_ids)):
        msg = msg + str(sensor_ids[i])
        if i != len(sensor_ids) - 1:
            msg = msg + ", "
    return msg

Given this code, how would you improve it? Point out anything you think is actually wrong, not just stylistic, and explain the impact each issue could have on a real home security system.