Dataford
Interview QuestionsInterview GuidesExperiencesCoaching
New
Pricing
Get started
Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
Experiences
Practice
Mock InterviewsTimed interview simulations with feedbackCoaching1:1 coaching with people at your target companiesSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Build my plan

Efficient, Readable Refactoring

MediumCoding00:00
Practice interviewer
In session
5 left
00:00

Your question is Efficient, Readable Refactoring. Take a moment with it on the right.

Talk me through your thinking if you like. When you're confident, submit your answer and I'll grade it like a real screen (7/10 or better passes).

You need to log in / sign up to chat or submit.

Problem

This PHP code at ABOUT YOU applies category discount rules across the product catalog and looks products up by ID for order processing. It works on small test catalogs, but a teammate flagged that discount totals look inconsistent between runs, and that catalog-wide jobs using it are much slower than they should be.

function applyDiscounts($products, $discountRules) {
    $result = [];
    foreach ($products as $product) {
        $finalPrice = $product['price'];
        foreach ($discountRules as $rule) {
            if ($rule['category'] == $product['category']) {
                $finalPrice = $finalPrice - ($finalPrice * $rule['percent'] / 100);
            }
        }
        $product['finalPrice'] = $finalPrice;
        array_push($result, $product);
    }
    return $result;
}

function getProductById($products, $id) {
    foreach ($products as $product) {
        if ($product['id'] == $id) {
            return $product;
        }
    }
    return null;
}

Refactor this to be more efficient while keeping it readable for the rest of the team. Point out both the performance problems and anything that could explain the inconsistent discount totals.