Dataford
Popular roles
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Browse
Browse All RolesEvery role hub, from analyst to MLBrowse All CompaniesCompany-specific interview loopsAll Interview GuidesThe full guide library
Top questions by role
Software EngineerData AnalystData ScientistData EngineerBusiness AnalystAI EngineerMachine Learning EngineerProduct Manager
Top questions by skill
SQLPythonStatisticsMachine LearningA/B TestingSystem DesignGenerative AIProduct SenseMetricsBehavioral
Browse all questions →Try a mock interview
ExperiencesCoaching
New
Practice
Mock InterviewsTimed interview simulations with feedbackSuccess PathYour 6-week structured planModulesCurated lessons by topicWebinarsTalks from ex-Big Tech data leadsPlaygroundA free-form scratch editor
Learn
BlogInterview strategy and career adviceTech Job Market ReportHiring trends across data and AI rolesFor UniversitiesDataford for career centersAbout DatafordWho we are and how we build
Pricing
Get started
Code Review for Quality
00:00
5 left

Code Review for Quality

MediumPython

Problem

Review an existing piece of code for syntax problems, poor structure, readability, and maintainability

Asked in the Superday Round 1 (coding & code review) stage. Implement a static reviewer for Python source code.

Input and Output

Implement review_code(code), where code is a Python source string. Return a sorted list of applicable issue labels: syntax_error, bare_except, deep_nesting, long_function, magic_number, missing_docstring, and unclear_names.

Use these rules: syntax errors return only syntax_error; nesting deeper than three control-flow levels adds deep_nesting; functions containing more than 12 statement nodes add long_function; numeric constants other than -1, 0, and 1 add magic_number; public functions without docstrings add missing_docstring; bare except clauses add bare_except; one-character names other than i, j, and k add unclear_names.

Constraints

  • 1 <= len(code) <= 10^5
  • code is a UTF-8 Python source string
  • Only static analysis is allowed; submitted code must not be executed
  • Return labels in lexicographic order without duplicates

Function Signature

def review_code(code):
Interviewer

Your question is Code Review for Quality. Start with the requirements in the Question tab.

Run and submit as often as you like. When you're ready, talk me through your approach or go straight to the code.

You need to log in / sign up to run or submit.
CodePython 3
Sign up free to run your codeLog inLn 2
Run your code to see test output here.