Code Review Deep Dive | Dataford Interview Questions

Tell me about a time a reviewer looked at your code and asked follow-up questions; how did you respond and improve it?

For the coding portion, implement review_order(comments, dependencies). Return an order for addressing review comments when each dependency [a, b] means comment a must be addressed before comment b. Return an empty list if the dependencies contain a cycle.

comments is a list of unique strings. dependencies is a list of two-element lists containing comment IDs. Return a list containing every comment exactly once, using lexicographically smallest choices when multiple comments are available.

Constraints

1 <= len(comments) <= 10^4
Comment IDs are unique strings
Each dependency contains exactly two existing comment IDs
A dependency from a comment to itself is allowed and makes the result invalid

Function Signature

def review_order(comments, dependencies):

Your question is Code Review Deep Dive. Start with the requirements in the Question tab.

Run and submit as often as you like. When you're ready, talk me through your approach or go straight to the code.

Problem

Tell me about a time a reviewer looked at your code and asked follow-up questions; how did you respond and improve it?

Constraints

1 <= len(comments) <= 10^4
Comment IDs are unique strings
Each dependency contains exactly two existing comment IDs
A dependency from a comment to itself is allowed and makes the result invalid

Function Signature

def review_order(comments, dependencies):

Your question is Code Review Deep Dive. Start with the requirements in the Question tab.

Run and submit as often as you like. When you're ready, talk me through your approach or go straight to the code.